asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: QueryService API updates
Date Thu, 07 Jul 2016 17:41:48 GMT
Yingyi Bu has posted comments on this change.

Change subject: QueryService API updates
......................................................................


Patch Set 19:

(2 comments)

Just one minor comment and one question.

https://asterix-gerrit.ics.uci.edu/#/c/896/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/APIServlet.java:

Line 61:     private static Logger LOGGER = Logger.getLogger(APIServlet.class.getName());
static final


https://asterix-gerrit.ics.uci.edu/#/c/896/19/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/QueryServiceServlet.java:

Line 454:         }
What's the advantage of this method compared to previous way that has a final member compilationProvider
in the class?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/896
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie67ad4ea31699400726c8c026c4a91edc698f2b5
Gerrit-PatchSet: 19
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message