Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Tue, 28 Jun 2016 18:22:02 -0700
From: "Till Westmann (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
To: Yingyi Bu <buyingyi@gmail.com>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reply-To: tillw@apache.org
Subject: Change in asterixdb[master]: Add IS (NOT) NULL/MISSING/UNKOWN.
In-Reply-To: <gerrit.1467073523739.I7e4008d97f0d3a92816b90492dd8c887b05bac27@asterix-gerrit.ics.uci.edu>
References: <gerrit.1467073523739.I7e4008d97f0d3a92816b90492dd8c887b05bac27@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20160629012202.8AE79241128@unhygienix.ics.uci.edu>
archived-at: Wed, 29 Jun 2016 01:22:05 -0000

Till Westmann has posted comments on this change.

Change subject: Add IS (NOT) NULL/MISSING/UNKOWN.
......................................................................


Patch Set 4: Code-Review+2

(1 comment)

I think that some of the formatting in the .jj file could be nicer, but it's not important. Feel free to forward the +2 if, you address the formatting in the .jj file.

https://asterix-gerrit.ics.uci.edu/#/c/963/4/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 1729:     ( <IS> (<NOT> {not = true; })? (<NULL> | <MISSING> | <UNKOWN>)
space between '{' and 'not'?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/963
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4008d97f0d3a92816b90492dd8c887b05bac27
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes