Return-Path: <notifications-return-12795-archive-asf-public=cust-asf.ponee.io@asterixdb.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id A6D77200B40
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 17 Jun 2016 04:49:16 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id A565B160A52; Fri, 17 Jun 2016 02:49:16 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id EE150160A51
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 17 Jun 2016 04:49:15 +0200 (CEST)
Received: (qmail 85505 invoked by uid 500); 17 Jun 2016 02:49:15 -0000
Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:notifications-help@asterixdb.apache.org>
List-Unsubscribe: <mailto:notifications-unsubscribe@asterixdb.apache.org>
List-Post: <mailto:notifications@asterixdb.apache.org>
List-Id: <notifications.asterixdb.apache.org>
Reply-To: dev@asterixdb.apache.org
Delivered-To: mailing list notifications@asterixdb.apache.org
Received: (qmail 85496 invoked by uid 99); 17 Jun 2016 02:49:15 -0000
Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Jun 2016 02:49:15 +0000
Received: from localhost (localhost [127.0.0.1])
	by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9DAAEC12E9
	for <notifications@asterixdb.apache.org>; Fri, 17 Jun 2016 02:49:14 +0000 (UTC)
X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org
X-Spam-Flag: NO
X-Spam-Score: 2.126
X-Spam-Level: **
X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31
	tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled
Received: from mx1-lw-eu.apache.org ([10.40.0.8])
	by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024)
	with ESMTP id qn4aRzSvjbXl for <notifications@asterixdb.apache.org>;
	Fri, 17 Jun 2016 02:49:12 +0000 (UTC)
Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130])
	by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id EA9475F232
	for <notifications@asterixdb.incubator.apache.org>; Fri, 17 Jun 2016 02:49:11 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by unhygienix.ics.uci.edu (Postfix) with ESMTP id 7A2532418E5;
	Thu, 16 Jun 2016 19:49:04 -0700 (PDT)
Date: Thu, 16 Jun 2016 19:49:04 -0700
From: "Michael Blow (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Preston Carman <prestonc@apache.org>,
	Ian Maxon <imaxon@apache.org>
Reply-To: michael.blow@couchbase.com
X-Gerrit-MessageType: comment
Subject: Change in asterixdb[master]: Use Maven Enforcer Plugin
X-Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
X-Gerrit-ChangeURL: <https://asterix-gerrit.ics.uci.edu/929>
X-Gerrit-Commit: 16415f72bf37897d3b2d24b600af362bee7e8639
In-Reply-To: <gerrit.1466112182950.I9c0042a3317b41c351c44d998141ea14e72971f5@asterix-gerrit.ics.uci.edu>
References: <gerrit.1466112182950.I9c0042a3317b41c351c44d998141ea14e72971f5@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20160617024904.7A2532418E5@unhygienix.ics.uci.edu>
archived-at: Fri, 17 Jun 2016 02:49:16 -0000

Michael Blow has posted comments on this change.

Change subject: Use Maven Enforcer Plugin
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/929/2/hyracks-fullstack/pom.xml
File hyracks-fullstack/pom.xml:

Line 29:     <groupId>org.apache</groupId>
> Making the asterixdb POM dependent on the parent POM is OK, but we shouldn'
It can be build independently of asterixdb, just not independent of the top-level pom.  If you don't want this to be a pom that has references to the asterix modules, we can use a separate parent pom, but I think we should try to avoid having copy/paste configuration in both asterixdb & hyracks.

e.g., you should able to rm -rf asterixdb, and the hyracks build should work.  I'm not breaking that.


https://asterix-gerrit.ics.uci.edu/#/c/929/2/pom.xml
File pom.xml:

Line 83:                   <version>3.3.9</version>
> Can we make the constraint a lower bound? I'm not sure enforcing down to mi
This syntax is lower bound.  It means v >= 3.3.9.  http://maven.apache.org/enforcer/enforcer-rules/versionRanges.html  If it would be clearer, I can use the standard syntax for specifying this: [3.3.9,)


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/929
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c0042a3317b41c351c44d998141ea14e72971f5
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-HasComments: Yes