Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.apache.org
Date: Tue, 14 Jun 2016 21:34:49 -0700
From: "abdullah alamoudi (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Yingyi Bu <yingyib@google.com>,
	Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Yingyi Bu <buyingyi@gmail.com>
Reply-To: bamousaa@gmail.com
Subject: Change in asterixdb[master]: Fix partitioning for datasets with meta
In-Reply-To: <gerrit.1465956749301.Ida2dfe2c54e4fa4ae3b4131ec5acc801fa89ca0d@asterix-gerrit.ics.uci.edu>
References: <gerrit.1465956749301.Ida2dfe2c54e4fa4ae3b4131ec5acc801fa89ca0d@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20160615043449.65B98240901@unhygienix.ics.uci.edu>
archived-at: Wed, 15 Jun 2016 04:35:01 -0000

abdullah alamoudi has submitted this change and it was merged.

Change subject: Fix partitioning for datasets with meta
......................................................................


Fix partitioning for datasets with meta

Change-Id: Ida2dfe2c54e4fa4ae3b4131ec5acc801fa89ca0d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/924
Reviewed-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Yingyi Bu <buyingyi@gmail.com>
---
M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Yingyi Bu: Looks good to me, approved
  Jenkins: Looks good to me, but someone else must approve; Verified


diff --git a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java
index f0bd603..0bc683c 100644
--- a/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java
+++ b/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/InsertDeleteUpsertPOperator.java
@@ -83,7 +83,11 @@
             IPhysicalPropertiesVector reqdByParent, IOptimizationContext context) {
         List<LogicalVariable> scanVariables = new ArrayList<LogicalVariable>();
         scanVariables.addAll(keys);
+        // Why do we add $$-1 and not the payLoad variable?
         scanVariables.add(new LogicalVariable(-1));
+        if (additionalNonFilteringFields != null) {
+            scanVariables.addAll(additionalNonFilteringFields);
+        }
         IPhysicalPropertiesVector r = dataSource.getPropertiesProvider().computePropertiesVector(scanVariables);
         r.getLocalProperties().clear();
         IPhysicalPropertiesVector[] requirements = new IPhysicalPropertiesVector[1];

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/924
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida2dfe2c54e4fa4ae3b4131ec5acc801fa89ca0d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>