Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id D7E12200AE4 for ; Fri, 10 Jun 2016 00:15:05 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id D6C15160A59; Thu, 9 Jun 2016 22:15:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 318A1160A58 for ; Fri, 10 Jun 2016 00:15:05 +0200 (CEST) Received: (qmail 12480 invoked by uid 500); 9 Jun 2016 22:15:04 -0000 Mailing-List: contact notifications-help@asterixdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.apache.org Delivered-To: mailing list notifications@asterixdb.apache.org Received: (qmail 12471 invoked by uid 99); 9 Jun 2016 22:15:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 09 Jun 2016 22:15:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id A3536C084F for ; Thu, 9 Jun 2016 22:15:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2.126 X-Spam-Level: ** X-Spam-Status: No, score=2.126 tagged_above=-999 required=6.31 tests=[MISSING_HEADERS=1.207, SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 5HCgo4hZ4fRo for ; Thu, 9 Jun 2016 22:15:01 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id DE74E5F36F for ; Thu, 9 Jun 2016 22:15:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id D4B9A2419D4; Thu, 9 Jun 2016 15:14:59 -0700 (PDT) Date: Thu, 9 Jun 2016 15:14:59 -0700 From: "abdullah alamoudi (Code Review)" CC: Jenkins , Till Westmann Reply-To: bamousaa@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Improve External Data X-Gerrit-Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9 X-Gerrit-ChangeURL: X-Gerrit-Commit: ce9d2d650a638fe2084853ba59a46cbd7924d00b In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160609221459.D4B9A2419D4@unhygienix.ics.uci.edu> archived-at: Thu, 09 Jun 2016 22:15:06 -0000 abdullah alamoudi has posted comments on this change. Change subject: Improve External Data ...................................................................... Patch Set 7: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java: Line 2003: mdTxnCtx); > Why do we "get" something that's not used? Could we remove it or add a comm Done https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordWithMetadataParser.java: Line 29: void appendPK(ArrayTupleBuilder tb) throws IOException; > We append a PK to a parser? That sounds confusing ... Done https://asterix-gerrit.ics.uci.edu/#/c/906/7/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPRequestToRecordWithMetadataAndPKConverter.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/DCPRequestToRecordWithMetadataAndPKConverter.java: Line 42: public class DCPRequestToRecordWithMetadataAndPKConverter > This class name seems sub-optimal. Done -- To view, visit https://asterix-gerrit.ics.uci.edu/906 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae2560c73fa63e9454f731b8e893ae779a2ac7d9 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes