asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix CC Nullpointer when Log Level > FINEST
Date Fri, 20 May 2016 02:19:01 GMT
Ian Maxon has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/870

Change subject: Fix CC Nullpointer when Log Level > FINEST
......................................................................

Fix CC Nullpointer when Log Level > FINEST

The Hyracks CC would nullpoint on startup if the log level was
greater than FINEST. Seems to be a concurrency issue related to
initialization of an AtomicInteger. This fixes that.

Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
---
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/70/870/1

diff --git a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
index 7786db7..3a34a07 100644
--- a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
+++ b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/work/WorkQueue.java
@@ -48,10 +48,8 @@
         thread = new WorkerThread();
         stopSemaphore = new Semaphore(1);
         stopped = true;
-        if (LOGGER.isLoggable(COUNT_LOGGING_LEVEL)) {
-            enqueueCount = new AtomicInteger(0);
-            dequeueCount = new AtomicInteger(0);
-        }
+        enqueueCount = new AtomicInteger(0);
+        dequeueCount = new AtomicInteger(0);
     }
 
     public void start() throws HyracksException {

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/870
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I720eca41fac312fc6cbdbb880162a5bc8b0357dc
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>

Mime
View raw message