asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Files necessary for initial perf regression tests
Date Fri, 27 May 2016 22:04:28 GMT
Till Westmann has posted comments on this change.

Change subject: Files necessary for initial perf regression tests
......................................................................


Patch Set 7:

(12 comments)

Got a few questions/comments, but it generally looks ok (even though I don't understand the
details..). 

One thing I'm wondering about is what we should do about hostnames/paths. Is it ok to submit
those? Would be nice if we didn't have to ...

https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java
File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/action/derived/RunSQLPPFileAction.java:

Line 71:         if(aqlFilePath.toFile().isDirectory()){
The formatting looks strange here.


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java
File asterixdb/asterix-experiments/src/main/java/org/apache/asterix/experiment/client/LSMExperimentSetRunner.java:

Line 29: import org.apache.asterix.experiment.builder.*;
Could we undo this?


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg.sqlpp:

Line 1: use experiments;
Do we need license headers here? Can we add them?


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-3-months.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-3-months.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-6-months.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-6-months.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-day.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-day.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-hour.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-hour.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-minute.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-minute.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-month.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-month.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-week.sqlpp
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/aql/agg_bench/agg-week.sqlpp:

Line 4: select element "string-length"(g.message) 
WS


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/asterix-agg.xml:

Line 1: <!--
UC license header.


https://asterix-gerrit.ics.uci.edu/#/c/884/7/asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/nuclear.xml
File asterixdb/asterix-experiments/src/main/resources/ingestion-experiment-binary-and-configs/configs/nuclear.xml:

Line 2:  ! Copyright 2009-2013 by The Regents of the University of California
UC license


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/884
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21e2d44ca46a4a28478d9ef256c4fa8d53f03dc9
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message