asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Hillery (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fixes and tweaks for running Asterix atop new config-managem...
Date Fri, 20 May 2016 23:56:13 GMT
Chris Hillery has posted comments on this change.

Change subject: Fixes and tweaks for running Asterix atop new config-management framework.
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/874/3/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java
File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/config/AsterixPropertiesAccessor.java:

Line 162:             String[] storeDirs = cfg.getString(section, "storagedir", "storage").trim().split(",");
> Did we give up on "iodevices"?
No, "iodevices" is a Hyracks-level configuration parameter (my initial code reading it here
was bogus).


Line 169:             stores.put(ncId, storeDirs);
> Just move this up to the declaration of storeDirs?
I copied this code from the other AsterixPropertiesAccessor, which did it in this order. I
can move them both if you wish.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/874
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3027c8c839f25ea858790bd3340187f4b11f213
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message