asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...
Date Fri, 20 May 2016 22:22:57 GMT
Yingyi Bu has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype based on parallel
streaming histogram.
......................................................................


Patch Set 21:

(35 comments)

https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.1.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.1.ddl.aql:

Line 20: 
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.2.update.aql:

Line 17:  * under the License.
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.3.query.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/global-rg/global-rg.3.query.aql:

Line 19: use dataverse test;
rename this file to global-rg.1.query.aql


Line 22:   for $x in [1.0, 2.0, double("3.0"), 3.1, 3.2, 3.3, 3.4] 
WS


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.1.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.1.ddl.aql:

Line 20: 
remove this file.


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.2.update.aql:

Line 16:  * specific language governing permissions and limitations
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.3.query.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/local-rg/local-rg.3.query.aql:

Line 13:  * software distributed under the License is distributed on an
rename this file to local-rg.1.query.aql


Line 22:   for $x in [1.0, 2.0, double("3.0"), 3.1, 3.2, 3.3, 3.4] 
WS


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.1.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.1.ddl.aql:

Line 8:  * with the License.  You may obtain a copy of the License at
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.2.update.aql:

Line 17:  * under the License.
remove this file.


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.3.query.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double-null/rg-double-null.3.query.aql:

Line 19: use dataverse test;
rename this file to rg-double-null.1.query.aql


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.1.ddl.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.1.ddl.aql:

Line 21: create dataverse test;
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.2.update.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.2.update.aql:

Line 12:  * Unless required by applicable law or agreed to in writing,
remove this file


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.3.query.aql
File asterixdb/asterix-app/src/test/resources/runtimets/queries/aggregate/rg-double/rg-double.3.query.aql:

Line 20: set partitions '2'
rename this file to rg-double.3.query.aql.


Line 22:   for $x in [1.0, 2.0, double("3.0"), 3.1, 3.2, 3.3, 3.4] 
WS


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 225:             "ceiling", 1);
code style doesn't seem right.


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java:

Line 47: public class LocalRangeGeneratorAggregateFunction extends AbstractRangeGeneratorAggregateFunction
{
Can't we use open lists for local/intermediate aggregate output?

In this way, we don't need reset the types all the time.
It will be very painful if where ever we want to use the ranges we need to setup the types
correctly.


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateDescriptor.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateDescriptor.java:

Line 47:     public void reset(IAType inputType, IAType outputType) {
remove type set.  Use open list.


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java:

Line 45:     public void step(IFrameTupleReference tuple) throws AlgebricksException {
why no implementation?


Line 52:         // TODO Auto-generated method stub
why no implementation?


Line 58:         // TODO Auto-generated method stub
why no implementation?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/formats/NonTaggedDataFormat.java:

Line 454:                     throws AlgebricksException {
remove the following three block


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHeapList.java:

Line 25: 
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IHistogram.java:

Line 26: /**
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/IQuantileList.java:

Line 24: import org.apache.hyracks.dataflow.std.range.structures.GenericQuantile;
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/AbstractQuantileList.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/AbstractQuantileList.java:

Line 26: 
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/DominantQuantile.java:

Line 23:     int iBin;
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericQuantile.java:

Line 24:         Comparable<GenericQuantile<K, V>> {
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericStreamingHistogram.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/GenericStreamingHistogram.java:

Line 38: 
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/MinDifferenceQuantileList.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/MinDifferenceQuantileList.java:

Line 26:         super();
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/MinSumCountQuantileList.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/structures/MinSumCountQuantileList.java:

Line 19: package org.apache.hyracks.dataflow.std.range.structures;
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/util/HistogramUtils.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/range/util/HistogramUtils.java:

Line 32: /**
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/range/TypeTranslateTest.java
File hyracks-fullstack/hyracks/hyracks-dataflow-std/src/test/java/org/apache/hyracks/dataflow/std/range/TypeTranslateTest.java:

Line 12:  * Unless required by applicable law or agreed to in writing,
move the class to org/apache/asterix/runtime/aggregates/std/range?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/data/skew/zipfan2.tbl
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/data/skew/zipfan2.tbl:

Line 3: 5.1143520826504275E7	9669	51143520	20291	-1171915.9960645214	3003	42424281	291	=kO98+.DI)QN#Z
what does this mean?


https://asterix-gerrit.ics.uci.edu/#/c/806/21/hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/HistogramAlgorithmTests.java
File hyracks-fullstack/hyracks/hyracks-examples/hyracks-integration-tests/src/test/java/org/apache/hyracks/tests/util/HistogramAlgorithmTests.java:

Line 6:  * to you under the Apache License, Version 2.0 (the
move the class to org/apache/asterix/runtime/aggregates/std/range?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 21
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes

Mime
View raw message