asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: WIP: TESTING GERRIT SONARQUBE REVIEWS
Date Thu, 19 May 2016 15:17:40 GMT
Michael Blow has posted comments on this change.

Change subject: WIP: TESTING GERRIT SONARQUBE REVIEWS
......................................................................


Patch Set 2:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/864/2/asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java
File asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/ClusterStateWatcher.java:

> MAJOR SonarQube violation:
Done


Line 38: 		this.clusterStatePath = ZooKeeperService.ASTERIX_INSTANCE_BASE_PATH + File.separator
+ clusterName + ZooKeeperService.ASTERIX_INSTANCE_STATE_PATH;
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/864/2/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java
File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/AsterixBuiltinFunctions.java:

Line 129:     public static final String fooBAR = "yeah this line is like way too long, but
i just need to see how existing failures will be reported.";
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/864/2/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeControllersInfoWork.java
File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetNodeControllersInfoWork.java:

Line 44:         synchronized(mutex) {
> BLOCKER SonarQube violation:
Done


Line 48:                 result.put(e.getKey(), new NodeControllerInfo(e.getKey(), NodeStatus.ALIVE,
e.getValue().getDataPort(), e
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/864/2/hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java
File hyracks-fullstack/hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/btree/OrderedIndexExamplesTest.java:

> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/864
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5742e30fc90266d29354f2f092b021f95ec85ff
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-HasComments: Yes

Mime
View raw message