asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Preston Carman (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: RangeGenerator aggfunc for the numeric/asciiString datatype ...
Date Tue, 10 May 2016 23:12:55 GMT
Preston Carman has posted comments on this change.

Change subject: RangeGenerator aggfunc for the numeric/asciiString datatype based on parallel
streaming histogram.
......................................................................


Patch Set 14:

(5 comments)

I did a quick glance over the code. 

Is this only the range aggregate functions? (We still need to bake this into the compiler
to get parallel sort, correct?)

https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/global-rg/global-avg.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/global-rg/global-avg.1.adm:

Line 1: [  ]
Why is the result empty? This seems like a bad test. Why create a range query that produces
no results?


https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/local-rg/local-rg.1.adm
File asterixdb/asterix-app/src/test/resources/runtimets/results/aggregate/local-rg/local-rg.1.adm:

Line 1: [  ]
Why is the result empty?


https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/scalar/ScalarRangeGeneratorAggregateDescriptor.java:

Line 29:     public final static FunctionIdentifier FID = AsterixBuiltinFunctions.SCALAR_RG;
Do you need this variable FID? Can this be inlined?


https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/LocalRangeGeneratorAggregateFunction.java:

Line 89:                     translateVal = new BytePointable();
Use factory to create pointable.


https://asterix-gerrit.ics.uci.edu/#/c/806/14/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java
File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/RangeGeneratorAggregateFunction.java:

Line 46:         // TODO Auto-generated method stub
Are these still in progress?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/806
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I450d0962fbeacfb2b6ab9fae0750f025ef17ba01
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <lwhaymail@yahoo.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-HasComments: Yes

Mime
View raw message