asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Overhaul of Hyracks configuration management.
Date Thu, 05 May 2016 02:21:10 GMT
Ian Maxon has posted comments on this change.

Change subject: Overhaul of Hyracks configuration management.
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

Overall seems fine to me, but have we tried mvn verify beforehand with this patch just out
of an abundance of caution?

https://asterix-gerrit.ics.uci.edu/#/c/336/5/hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml
File hyracks-fullstack/hyracks/hyracks-control/hyracks-nc-service/pom.xml:

Line 63:         <version>0.2.18-SNAPSHOT</version>
Should change this to be ${hyracks.version}


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/336
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3027c8c839f25ea858790bd3340187f4b11f212
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message