asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Set LSMRTreeWithAntiMatterTuples as the default RTree for in...
Date Tue, 03 May 2016 04:37:42 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Set LSMRTreeWithAntiMatterTuples as the default RTree for interal dataset
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/838/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java
File asterixdb/asterix-app/src/main/java/org/apache/asterix/file/SecondaryRTreeOperationsHelper.java:

Line 321:             IIndexDataflowHelperFactory idff = null;
> Why the set to null then initialize here? Also I guess I am trying to under
I changed the code not to have the null initialization.
getComparatorFactoriesForDeletedKeyBTree() is for the deleted-key-btree of the in-memory component.
Again, still, LSMRTreeWithAntimatterTuples maintains a deleted-key-btree for the in-memory
component. So, this is not about backwards compat.


https://asterix-gerrit.ics.uci.edu/#/c/838/2/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java
File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/AbstractLSMRTree.java:

Line 376:     protected LSMRTreeOpContext createOpContext(IModificationOperationCallback modCallback,
> What's the purpose of this new callback? Is it because the antimatter RTree
This was a bug which doesn't provide a proper search callback. So, I fixed it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/838
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19323ef38335409bc914265502ae56655db6d106
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Young-Seok Kim <kisskys@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message