Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D141819972 for ; Sat, 16 Apr 2016 04:31:23 +0000 (UTC) Received: (qmail 40899 invoked by uid 500); 16 Apr 2016 04:31:23 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 40862 invoked by uid 500); 16 Apr 2016 04:31:23 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 40853 invoked by uid 99); 16 Apr 2016 04:31:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 16 Apr 2016 04:31:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 39D191A0828 for ; Sat, 16 Apr 2016 04:31:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id S1FWNDFOIoT5 for ; Sat, 16 Apr 2016 04:31:21 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTP id E1A395F24D for ; Sat, 16 Apr 2016 04:31:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id D349D240728; Fri, 15 Apr 2016 21:26:03 -0700 (PDT) Date: Fri, 15 Apr 2016 21:26:03 -0700 From: "Taewoo Kim (Code Review)" To: Preston Carman CC: Till Westmann , Taewoo Kim , Jenkins Reply-To: wangsaeu@yahoo.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Refactored the AbstractComparisonEvaluator. X-Gerrit-Change-Id: I42e0e8cf71207bb862334cd0629e8c024ff0556c X-Gerrit-ChangeURL: X-Gerrit-Commit: 50d22d2dea83eb009e6e9b1a518a3afdacab61e2 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160416042603.D349D240728@unhygienix.ics.uci.edu> Taewoo Kim has posted comments on this change. Change subject: Refactored the AbstractComparisonEvaluator. ...................................................................... Patch Set 1: (5 comments) Totally agreed to Till's opinion. https://asterix-gerrit.ics.uci.edu/#/c/801/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonUtil.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/comparisons/ComparisonUtil.java: Line 436: private final int compareByte(int v1, int v2) { > Do we actually need -1, 0, 1 for these or would the difference work as well I think this is more clear : -1, 0, 1. :-) https://asterix-gerrit.ics.uci.edu/#/c/801/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/AbstractIntervalLogicFuncDescriptor.java: Line 107: if (interval0.getType() != interval0.getType()) { Maybe interval0.getType() != interval1.getType() ??? https://asterix-gerrit.ics.uci.edu/#/c/801/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/temporal/GetOverlappingIntervalDescriptor.java: Line 105: if (interval0.getType() != interval0.getType()) { An independent comment: maybe interval0.getType() != interval1.getType() ??? https://asterix-gerrit.ics.uci.edu/#/c/801/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/IComparable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/api/IComparable.java: Line 22: public int compareTo(byte[] bytes, int start, int length); > Are you sure it's ok to remove this Hyracks interface? Seems risky for othe Agreed. https://asterix-gerrit.ics.uci.edu/#/c/801/1/hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java File hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/TaggedValuePointable.java: Line 26: public class TaggedValuePointable extends AbstractPointable { > Oh, wow, we get one of those in Hyracks now :) Hyracks should not know the existence of type tag, right? Maybe this class needs to be moved? -- To view, visit https://asterix-gerrit.ics.uci.edu/801 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42e0e8cf71207bb862334cd0629e8c024ff0556c Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Preston Carman Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes