asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <>
Subject Change in asterixdb[master]: ASTERIXDB-1407: let the build branch to broadcast for Nested...
Date Fri, 22 Apr 2016 20:15:05 GMT
Jianfeng Jia has posted comments on this change.

Change subject: ASTERIXDB-1407: let the build branch to broadcast for NestedLoopJoin.

Patch Set 4:


I left a few minor comments. 
Just want to verify, for all the joins( NLJoin, HashJoin) we are broadcasting the build part,
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/

Line 61:  * Right input can be partitioned in any way.
Update this comments? We broadcast the right side, right?

Line 117:         pv[0] = new StructuralPropertiesVector(null, null);
Maybe add a TODO here for the statistical patch to optimize which part to broadcast if the
size information is available?
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/

Line 82:         // might not be able to execute correctly, i.e.,
would it be the reason for the *temporary file not found* problem?

Line 87:                 new String[] { clusterLocations.getLocations()[Math.abs(jobSpec.hashCode()
% nPartitions)] });
Just curious, why do we need this random number `Math.abs(jobSpec.hashCode()` and the what
the difference between old `new AlgebricksCountPartitionConstraint(1)` ?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I0988624406d2f7460f0ee5ac7b4829d81e48c652
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-HasComments: Yes

View raw message