asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1407: let the build branch to broadcast for Nested...
Date Fri, 22 Apr 2016 20:15:05 GMT
Jianfeng Jia has posted comments on this change.

Change subject: ASTERIXDB-1407: let the build branch to broadcast for NestedLoopJoin.
......................................................................


Patch Set 4:

(4 comments)

I left a few minor comments. 
Just want to verify, for all the joins( NLJoin, HashJoin) we are broadcasting the build part,
right?

https://asterix-gerrit.ics.uci.edu/#/c/828/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NLJoinPOperator.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/NLJoinPOperator.java:

Line 61:  * Right input can be partitioned in any way.
Update this comments? We broadcast the right side, right?


Line 117:         pv[0] = new StructuralPropertiesVector(null, null);
Maybe add a TODO here for the statistical patch to optimize which part to broadcast if the
size information is available?


https://asterix-gerrit.ics.uci.edu/#/c/828/4/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java
File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/jobgen/impl/JobBuilder.java:

Line 82:         // might not be able to execute correctly, i.e.,
would it be the reason for the *temporary file not found* problem?


Line 87:                 new String[] { clusterLocations.getLocations()[Math.abs(jobSpec.hashCode()
% nPartitions)] });
Just curious, why do we need this random number `Math.abs(jobSpec.hashCode()` and the what
the difference between old `new AlgebricksCountPartitionConstraint(1)` ?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/828
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0988624406d2f7460f0ee5ac7b4829d81e48c652
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message