asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <>
Subject Change in asterixdb[master]: Update the Key Value Reader
Date Tue, 19 Apr 2016 01:10:05 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Update the Key Value Reader

Patch Set 2:

File asterixdb/asterix-external-data/pom.xml:

Line 296:         </dependency>
> Why is the order different now? Should just be the version number, right?
Yes. can I blame the eclipse m2e plugin?
File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/kv/

Line 99:         this.pushThread = new Thread(new Runnable() {
> Should this use some ThreadPool?
I don't think so. It is just a thread per partition.
Maybe we do but let's wait and see if we need it, then we will do it?

Line 102:       ;
> How do we cleanly stop this thread?
I think there is no clean way to do that now. we just interrupt it and it should terminate

Line 113:             connection.subject().takeUntil(Observable.never()).toBlocking().forEach(new
Action1<DCPRequest>() {
> * Isn't takeUntil(Observable.never()) redundant?
could be. I am not sure but will give it a try without and see what happens

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I54f8a313c871428b2468b74c0760e8d28e810699
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message