asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: ASTERIXDB-1287: Fixed Admin Console pages.
Date Wed, 06 Apr 2016 20:06:46 GMT
Till Westmann has posted comments on this change.

Change subject: ASTERIXDB-1287: Fixed Admin Console pages.
......................................................................


Patch Set 4:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/557/4//COMMIT_MSG
Commit Message:

Line 25: raw JSON data sent to it.
Please follow the formatting guidelines for commit messages [1].

[1] https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting


https://asterix-gerrit.ics.uci.edu/#/c/557/4/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
File hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java:

Line 21: import java.util.*;
We usually don't use "*" includes. And as this is the only change here, the file should be
reverted.


https://asterix-gerrit.ics.uci.edu/#/c/557/4/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/json.human.js
File hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/json.human.js:

Line 21: // THE SOFTWARE.
We need to update the LICENSE and NOTICE for this.


https://asterix-gerrit.ics.uci.edu/#/c/557/4/hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/stylesheet/json.human.css
File hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/stylesheet/json.human.css:

Line 21: // THE SOFTWARE.
We need to update the LICENSE and NOTICE for this.


https://asterix-gerrit.ics.uci.edu/#/c/557/4/pom.xml
File pom.xml:

Line 211:            <exclude>**/stylesheet/json.human.css</exclude>
Can we be more precise here (not "**")?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/557
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540
Gerrit-PatchSet: 4
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Pritom Ahmed <pritom.11@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Pritom Ahmed <pritom.11@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message