asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Hillery (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Allow for optional modules in build.
Date Wed, 06 Apr 2016 09:47:42 GMT
Chris Hillery has posted comments on this change.

Change subject: Allow for optional modules in build.
......................................................................


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/768/3/asterix-server/pom.xml
File asterix-server/pom.xml:

Line 53:           <useWildcardClassPath>true</useWildcardClassPath>
This is not strictly necessary, but it makes the resulting asterixnc/asterixcc scripts neater.


Line 137:           <exists>../asterix-opt/pom.xml</exists>
Profile activation is not inherited from parent modules, or perhaps a profile defined in a
child overrides the parent profile. In any case, I couldn't find a neater way than this to
cause the optional behaviour to activate both here and in the top-level pom.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/768
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib99bfb3f92dfaa66dc2299db31b734adb5cceeca
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Chris Hillery <ceej@lambda.nu>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message