asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1356: report file not found
Date Wed, 06 Apr 2016 07:10:09 GMT
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1356: report file not found
......................................................................


Patch Set 8:

With the current implementation, a few things can go wrong IMO:

1. if a user specified a directory path and the path was found to be empty, we throw an exception.
I don't think that is the correct behavior.
What I would expect:
If the directory is found, then regardless of whether it contains files or not, this should
not throw an exception.

2. if a user specified a set of paths in a single NC, The first path was found to have at
least one file, even if we don't find the other paths at all, no exception is thrown.
What I would expect:
If any of the passed paths doesn't exist, we throw an exception.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/771
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia12bf84adfd8442103567df42ac22e5750e1360f
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: No

Mime
View raw message