asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Murtadha Hubail (Code Review)" <>
Subject Change in asterixdb[master]: Control Number of Readers for LocalFS Data
Date Sun, 03 Apr 2016 09:25:17 GMT
Murtadha Hubail has posted comments on this change.

Change subject: Control Number of Readers for LocalFS Data

Patch Set 3:

File asterix-app/src/main/java/org/apache/asterix/app/external/

Line 69:      * 
File asterix-app/src/test/resources/runtimets/testsuite.xml:

Line 53:     <test-group name="feeds">
Revert this file
File asterix-external-data/src/main/java/org/apache/asterix/external/api/

Line 30:  * 

Line 51:      * 

Line 67:      * 
File asterix-external-data/src/main/java/org/apache/asterix/external/api/

Line 24:     public void notifyNewSource() throws IOException;
change exception to HyracksDataException and add java docs.
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/converter/

Line 50:         try {
remove try/catch. is there a reason to keep it?
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/

Line 123:     public void notifyNewSource() throws IOException {
throw unsupported?
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/factory/

Line 130:         // After this change, each node partition which has at least one file
Remove "After this change" and make comment clearer

Line 131:         Map<String, String[]> stores = AsterixAppContextInfo.getInstance().getMetadataProperties().getStores();
use getMetadataProperties().getNodePartitions to make it clearer
File asterix-external-data/src/main/java/org/apache/asterix/external/util/

Line 77:         try {
do you need some kind of protection here in case multiple partitions call init?
File asterix-external-data/src/main/java/org/apache/asterix/external/util/

Line 62:                         return value;

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9d5ece656220d5f562cc385f882c5ddfd3283a6
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Murtadha Hubail <>
Gerrit-HasComments: Yes

View raw message