asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1378 Fix NPE on Feed Connect After Restart
Date Fri, 01 Apr 2016 06:18:27 GMT
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1378 Fix NPE on Feed Connect After Restart
......................................................................


Patch Set 1:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java
File asterix-app/src/main/java/org/apache/asterix/file/DatasetOperations.java:

Line 237:         ITypeTraits[] typeTraits = DatasetUtils.computeTupleTypeTraits(dataset,
itemType, metaItemType);
> Can't we move more of the computation into the DatasetUtils?
Done


https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java
File asterix-app/src/test/java/org/apache/asterix/test/runtime/ExecutionTest.java:

Line 98:     int i = 0;
> This is unused.
Yes. sorry I forgot to remove it :)


https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java:

Line 89:             LOGGER.warn("Feed has been interrupted. Closing the feed");
> InterruptedException only happens if somebody interrupts the thread. Why do
I am assuming it is only interrupted by request and so would like to not give a chance to
recover.


https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtils.java
File asterix-metadata/src/main/java/org/apache/asterix/metadata/utils/DatasetUtils.java:

Line 154:             throws AlgebricksException {
> I'm confused about this change. If I reformat the file with the eclipse for
Mmmm, I think this is my problem since I am unsatisfied with out formatter so I added a few
tweaks and I think that I shouldn't have done that :)


https://asterix-gerrit.ics.uci.edu/#/c/766/1/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/AsterixLSMPrimaryUpsertOperatorNodePushable.java:

Line 197:         accessor.prettyPrint();
> Where does this print to? Should this be removed?
Yes. Added it for debugging. will surely remove it


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/766
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8f8696d252868a8cce0afdbaeda0dd046f99186
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message