asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ian Maxon (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Fixed Bugs Caused by Disabling Installer Tests
Date Mon, 21 Mar 2016 19:20:02 GMT
Ian Maxon has posted comments on this change.

Change subject: Fixed Bugs Caused by Disabling Installer Tests
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/736/2/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java
File hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java:

Line 566:                 bloomFilter.deactivate();
> @Ian,
There shouldn't be. I just never had an issue with them due to the way they're built, so I
never made it purge the handle like the trees.


Line 616:         if (createComponent) {
> maybe you don't need to create but definitely need to activate, otherwise, 
The bulk loader itself (so the individual bulkloaders of the BTree and buddy BTree) should
be calling create/activate now. You shouldn't have to call it here, I think. Was something
breaking?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/736
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic77f4ee76a77f4b49cac6835bbb976eb9dc92d3a
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message