asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Improve Error Handling in Local Directory Feeds
Date Mon, 21 Mar 2016 08:37:50 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Improve Error Handling in Local Directory Feeds
......................................................................


Patch Set 4:

(15 comments)

https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.4.sleep.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/feeds_08/feeds_08.4.sleep.aql:

Line 22:                   The synthetic feed simulator uses the Social-Data generator to
generate data and simulate a feed.
> line break
Done


Line 23:                   The feed lasts a configured duration with data arriving at a configured
rate (tweets per second).
> line break
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/api/AsterixInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/AsterixInputStream.java:

Line 33:     public abstract boolean handle(Throwable th);
> rename to handleException
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/api/IIndexingDatasource.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IIndexingDatasource.java:

Line 29: 
> add java docs to methods
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:

Line 70:     public boolean handle(Throwable th);
> rename to handleException
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java
File asterix-external-data/src/main/java/org/apache/asterix/external/indexing/FileOffsetIndexer.java:

Line 55
> return this TODO
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/AbstractStreamRecordReader.java:

Line 100:     @Override
> These methods are usable only in HDFS case. Think about restructuring the i
I have a design that would solve this but would rather have it in a separate change!


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/stream/SemiStructuredRecordReader.java:

Line 103:                         reader.reset();
> Make sure the reader is closed in case of exceptions
It will always be closed in a subsequent call to close()


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPullRecordReader.java:

Line 94:     @Override
> remove the super class methods below
can't do that. super is an interface and I want to force every class to provide its implementation.


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/record/reader/twitter/TwitterPushRecordReader.java:

Line 129:     @Override
> remove the super class methods below
can't do that. super is an interface and I want to force every class to provide its implementation.


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AsterixInputStreamReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/AsterixInputStreamReader.java:

Line 117:     public void reset() {
> Missing implementation.
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketClientInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/SocketClientInputStream.java:

Line 41:         throw new IOException("method not supported. use read(byte[] buffer, int
offset, int length) instead");
> change to unsupported or use in.read
Done


Line 53:                 in.close();
> You don't need to close the inputStream as well as the socket. Just close o
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java
File asterix-external-data/src/main/java/org/apache/asterix/external/input/stream/TwitterFirehoseInputStream.java:

Line 78:             started = true;
> this will be set in start()
Done


https://asterix-gerrit.ics.uci.edu/#/c/720/4/asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FileSystemWatcher.java:

Line 58:     public FileSystemWatcher(Path inputResource, String expression, boolean isFeed)
throws IOException {
> No need to throw
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/720
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08d89229e33c91532b1038ba9f7a372f7ca1fdb5
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message