asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <>
Subject Change in hyracks[master]: Support Change Feeds and Ingestion of Records with MetaData
Date Mon, 14 Mar 2016 16:36:21 GMT
Yingyi Bu has posted comments on this change.

Change subject: Support Change Feeds and Ingestion of Records with MetaData

Patch Set 9:

File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/expressions/

Line 151:         Iterator<Mutable<ILogicalExpression>> it = arguments.iterator();
Do you still need this method?
File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/

Line 107:                 insertDeleteOp.getAdditionalNonFilteringExpressions(), inputDesc,
context, spec, true);
pass a list of variables for additionalNonFilteringFields.
File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/

Line 68:             return e.getMessage();
Throws this exception out.
File algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/

Line 312:                         ArrayList<LogicalVariable> additionalNonFilterVariables
= null;

Line 317:                                         .add(((VariableReferenceExpression) expr.getValue()).getVariableReference());
Use the Java8 feature?

foor loop


Expressions().foreach(expr -> additionalNonFilterVariables
                                  .add(((expr) expr.getValue()).getVari
File hyracks/hyracks-dataflow-common/src/main/java/org/apache/hyracks/dataflow/common/comm/io/

Line 209:             e.printStackTrace();
throws exception out?

Line 230:                 e.printStackTrace();
throws exception out?
File hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/

Line 84:     }
It would be nice to keep the class immutable. Thus, it's nice to remove this set method to
be consistent with other members, unless it is absolutely necessary.

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I3749349e2b9f1b03c8b310eb99d3f44d08be77df
Gerrit-PatchSet: 9
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Ildar Absalyamov <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Steven Jacobs <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message