asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1337: Dataset Memory Management on Multi-Partition NC
Date Fri, 11 Mar 2016 22:06:26 GMT
Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1337: Dataset Memory Management on Multi-Partition NC
......................................................................


Patch Set 3:

(9 comments)

https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java
File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContext.java:

Line 367:     }
> It seems that we could remove this method from here, as the DatasetLifecycl
Done


Line 372:     }
> It seems that we could remove this method from here, as the DatasetLifecycl
leaving this as-is for now, will revisit in future


https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContextProdiverForRecovery.java
File asterix-app/src/main/java/org/apache/asterix/api/common/AsterixAppRuntimeContextProdiverForRecovery.java:

Line 93:     }
> It seems that we could remove this method from here, as the DatasetLifecycl
Done


Line 98:     }
> It seems that we could remove this method from here, as the DatasetLifecycl
leaving this as-is for now, will revisit in the future.


https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java
File asterix-common/src/main/java/org/apache/asterix/common/api/IAsterixAppRuntimeContext.java:

Line 68:     public ILSMOperationTracker getLSMBTreeOperationTracker(int datasetID);
> It seems that we could remove this method from here, as the DatasetLifecycl
Leaving this as-is for now, will revisit in the future.


https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java
File asterix-common/src/main/java/org/apache/asterix/common/context/AsterixVirtualBufferCacheProvider.java:

Line 40:         int ioDeviceNum = fileSplitProvider.getFileSplits()[ctx.getTaskAttemptId().getTaskId().getPartition()]
> Create a variable for the taskPartitionId?
Done


https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-common/src/main/java/org/apache/asterix/common/transactions/IAsterixAppRuntimeContextProvider.java
File asterix-common/src/main/java/org/apache/asterix/common/transactions/IAsterixAppRuntimeContextProvider.java:

Line 49:     public ILSMOperationTracker getLSMBTreeOperationTracker(int datasetID);
> It seems that we could remove this method from here, as the DatasetLifecycl
Leaving this as-is for now, will revisit in the future.


Line 59:     public List<IVirtualBufferCache> getVirtualBufferCaches(int datasetID,
int ioDeviceNum);
> It seems that we could remove this method from here, as the DatasetLifecycl
Done


https://asterix-gerrit.ics.uci.edu/#/c/705/3/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMBTreeLocalResourceMetadata.java
File asterix-transactions/src/main/java/org/apache/asterix/transaction/management/resource/LSMBTreeLocalResourceMetadata.java:

Line 67:         List<IVirtualBufferCache> virtualBufferCaches = runtimeContextProvider.getVirtualBufferCaches(datasetID,
ioDeviceNum);
> Might need a variable for the DatasetLifecycleManager here, if we remove th
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/705
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbf08f532c1210c30be6a51c73570a789174213b
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message