asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Jacobs (Code Review)" <>
Subject Change in asterixdb[master]: Equivalence induced operations and the testCases The followi...
Date Fri, 11 Mar 2016 19:40:04 GMT
Steven Jacobs has posted comments on this change.

Change subject: Equivalence induced operations and the testCases The following commits from
your working branch will be included: exchange optimization for lookup and delete when the
search condition is merely composed of the single primary key.

Patch Set 13:


One thing that isn't clear for me: Does this only cover the case where the result comes from
a single partition, or can it also handle cases where there is a subset of partitions to be

This change needs tests (both optimizer and runtime).
File asterix-algebra/src/main/java/org/apache/asterix/algebra/operators/physical/

Line 94:         return isSinglePartition;
It seems like you don't need the boolean variable. You can just check here whether partitionId
is -1 or not.
File asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/

Line 696:                     spPc = splitProviderAndPartitionConstraintsForDataset(dataset.getDataverseName(),
should "curIdx != null"

Line 1148:             if (-1 != nodeId)
nodeId != -1

Line 1978:             if (-1 != nodeId)
nodeId != -1

Line 2639:             if (-1 != nodeId)
nodeId != -1

Line 2965:             if (-1 != nodeId)
nodeId != -1

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaad567eecc4c91019ecba56cca085acde34d5196
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wenhai Li <>
Gerrit-Reviewer: Ildar Absalyamov <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Jianfeng Jia <>
Gerrit-Reviewer: Steven Jacobs <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: Yingyi Bu <>
Gerrit-HasComments: Yes

View raw message