asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <>
Subject Change in hyracks[master]: Support Change Feeds and Ingestion of Records with MetaData
Date Mon, 07 Mar 2016 14:52:41 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Support Change Feeds and Ingestion of Records with MetaData

Patch Set 1:

File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/metadata/

Line 46:      * @param list 
> WS
File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/plan/

Line 68:         return prettyPlan;
> How about
File hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/dataset/

Line 79:             //"Result state cleanup instance successfully completed.");
> That's not strictly part of this change, is it? :)

Line 79:             //"Result state cleanup instance successfully completed.");
> If you believe the logging is too aggressive here may be it's better to cha
File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

Line 370:     public void searchForUpsert(ILSMIndexOperationContext ctx, IIndexCursor cursor,
ISearchPredicate searchPred) {
> I didn't get that: LSMHarness seems to be the only implementation of ILSMHa
You are right. the design of this change has changed during implementation causing this to
be left behind.
File hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/

Line 103:     public void searchForUpsert(IIndexCursor cursor, ISearchPredicate searchPred)
> Does that method get called anywhere?

To view, visit
To unsubscribe, visit

Gerrit-MessageType: comment
Gerrit-Change-Id: I3749349e2b9f1b03c8b310eb99d3f44d08be77df
Gerrit-PatchSet: 1
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <>
Gerrit-Reviewer: Ildar Absalyamov <>
Gerrit-Reviewer: Jenkins <>
Gerrit-Reviewer: Steven Jacobs <>
Gerrit-Reviewer: Till Westmann <>
Gerrit-Reviewer: abdullah alamoudi <>
Gerrit-HasComments: Yes

View raw message