Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 56E7F183A8 for ; Fri, 12 Feb 2016 18:55:40 +0000 (UTC) Received: (qmail 76044 invoked by uid 500); 12 Feb 2016 18:55:40 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 76009 invoked by uid 500); 12 Feb 2016 18:55:40 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 76000 invoked by uid 99); 12 Feb 2016 18:55:40 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 18:55:40 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id AE1E71A0548 for ; Fri, 12 Feb 2016 18:55:39 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id uSOPU6uXvHK3 for ; Fri, 12 Feb 2016 18:55:37 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E32355FC29 for ; Fri, 12 Feb 2016 18:55:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 35BB32419A7; Fri, 12 Feb 2016 10:51:15 -0800 (PST) Date: Fri, 12 Feb 2016 10:51:15 -0800 From: "Michael Blow (Code Review)" To: Yingyi Bu CC: Jenkins , Jianfeng Jia , abdullah alamoudi , Till Westmann , Preston Carman Reply-To: michael.blow@couchbase.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Move to non-copy-based evaluator interfaces for all function... X-Gerrit-Change-Id: If132857cf8d707ce96951f12ba6dd86f54aa4069 X-Gerrit-ChangeURL: X-Gerrit-Commit: 6b6a43fd7dfc14ea534487cdc63bddd7158ecf78 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160212185115.35BB32419A7@unhygienix.ics.uci.edu> Michael Blow has posted comments on this change. Change subject: Move to non-copy-based evaluator interfaces for all function implementations, including: - scalar functions, - aggregate functions, - running aggregate functions, - unnesting functions ...................................................................... Patch Set 14: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/615/14/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/accessors/TemporalDayAccessor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/accessors/TemporalDayAccessor.java: Line 63: * @see org.apache.asterix.runtime.base.IScalarFunctionDynamicDescriptor#createEvaluatorFactory(org.apache.hyracks.algebricks.runtime.base.ICopyEvaluatorFactory[]) Should this be ICopyEvaluatorFactory -> IScalarEvaluatorFactory? https://asterix-gerrit.ics.uci.edu/#/c/615/14/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/accessors/TemporalHourAccessor.java File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/accessors/TemporalHourAccessor.java: Line 64: * @see org.apache.asterix.runtime.base.IScalarFunctionDynamicDescriptor#createEvaluatorFactory(org.apache.hyracks.algebricks.runtime.base.ICopyEvaluatorFactory[]) ICopyEvaluatorFactory->IScalarEvaluatorFactory -- To view, visit https://asterix-gerrit.ics.uci.edu/615 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If132857cf8d707ce96951f12ba6dd86f54aa4069 Gerrit-PatchSet: 14 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Yingyi Bu Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Preston Carman Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes