Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id AA79D18D4C for ; Fri, 12 Feb 2016 02:49:28 +0000 (UTC) Received: (qmail 65538 invoked by uid 500); 12 Feb 2016 02:49:28 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 65505 invoked by uid 500); 12 Feb 2016 02:49:28 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 65496 invoked by uid 99); 12 Feb 2016 02:49:28 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Feb 2016 02:49:28 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 393AA1A03A4 for ; Fri, 12 Feb 2016 02:49:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-us-west.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id TNiPu__EcmAH for ; Fri, 12 Feb 2016 02:49:26 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-west.apache.org (ASF Mail Server at mx1-us-west.apache.org) with ESMTP id 3F2C820428 for ; Fri, 12 Feb 2016 02:49:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 582742419C7; Thu, 11 Feb 2016 18:45:05 -0800 (PST) Date: Thu, 11 Feb 2016 18:45:05 -0800 From: "Yingyi Bu (Code Review)" To: Jianfeng Jia CC: Jenkins , Yingyi Bu , Taewoo Kim Reply-To: buyingyi@gmail.com X-Gerrit-MessageType: comment Subject: Change in hyracks[master]: Intersect the 2ndary indexes before primary search X-Gerrit-Change-Id: Ic16c67c529ca19d8b1a5439ddef22760945fd0d7 X-Gerrit-ChangeURL: X-Gerrit-Commit: 9426d2302cdd599e3673bc9912d225e15364f5a7 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160212024505.582742419C7@unhygienix.ics.uci.edu> Yingyi Bu has posted comments on this change. Change subject: Intersect the 2ndary indexes before primary search ...................................................................... Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/577/2/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IntersectPOperator.java File algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/physical/IntersectPOperator.java: Line 89: List propsLocal = op.getDeliveredPhysicalProperties().getLocalProperties(); > I'm not following the comment. Could you give me some more hints or example This logic here should be very similar to AbstractJoinPOperator.computeDeliveredProperties(...) In addition, the operator should also deliver local ordering property on the primary key variable, because the output is according to the primary key. -- To view, visit https://asterix-gerrit.ics.uci.edu/577 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic16c67c529ca19d8b1a5439ddef22760945fd0d7 Gerrit-PatchSet: 2 Gerrit-Project: hyracks Gerrit-Branch: master Gerrit-Owner: Jianfeng Jia Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: Yes