Mailing-List: contact notifications-help@asterixdb.incubator.apache.org;
 run by ezmlm
Precedence: bulk
Reply-To: dev@asterixdb.incubator.apache.org
Date: Mon, 8 Feb 2016 21:52:38 -0800
From: "Yingyi Bu (Code Review)" <do-not-reply@asterixdb.incubator.apache.org>
CC: Jenkins <jenkins@fulliautomatix.ics.uci.edu>,
	Jianfeng Jia <jianfeng.jia@gmail.com>,
	abdullah alamoudi <bamousaa@gmail.com>,
	Michael Blow <michael.blow@couchbase.com>,
	Till Westmann <tillw@apache.org>,
	Preston Carman <prestonc@apache.org>
Reply-To: buyingyi@gmail.com
Subject: Change in asterixdb[master]: Move to non-copy-based evaluator
 interfaces for all function...
In-Reply-To: 
 <gerrit.1454639104269.If132857cf8d707ce96951f12ba6dd86f54aa4069@asterix-gerrit.ics.uci.edu>
References: 
 <gerrit.1454639104269.If132857cf8d707ce96951f12ba6dd86f54aa4069@asterix-gerrit.ics.uci.edu>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
User-Agent: Gerrit/2.8.4
Message-Id: <20160209055238.E9E8B2418B9@unhygienix.ics.uci.edu>

Yingyi Bu has posted comments on this change.

Change subject: Move to non-copy-based evaluator interfaces for all function implementations, including: - scalar functions, - aggregate functions, - running aggregate functions, - unnesting functions
......................................................................


Patch Set 7:

(14 comments)

https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-app/src/test/resources/runtimets/results/string/substring-after-4/substring-after-4.1.adm
File asterix-app/src/test/resources/runtimets/results/string/substring-after-4/substring-after-4.1.adm:

Line 1: { "result1": "HEllow", "result2": null, "result3": null, "result4": "", "result5": null }
> Why are there changes in the query result?
The old result is wrong.
The query is this:

let $c1 := substring-after("HEllow","")

let $c2 := substring-after("HEllow",null)

let $c3 := substring-after("",null)

let $c4 := substring-after("","")

let $c5 := substring-after(null,null)

return {"result1": $c1, "result2": $c2, "result3": $c3, "result4": $c4, "result5": $c5}

Null input should result in null output, for this case.


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-app/src/test/resources/runtimets/results/string/substring-before-3/substring-before-3.1.adm
File asterix-app/src/test/resources/runtimets/results/string/substring-before-3/substring-before-3.1.adm:

Line 1: { "result1": "", "result2": null, "result3": null, "result4": "", "result5": null }
> Why are there changes in the query result?
The old is wrong. The query is this:

let $c1 := substring-before("HEllow","")

let $c2 := substring-before("HEllow",null)

let $c3 := substring-before("",null)

let $c4 := substring-before("","")

let $c5 := substring-before(null,null)

return {"result1": $c1, "result2": $c2, "result3": $c3, "result4": $c4, "result5": $c5}

Any null parameter should result in null output.


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-om/src/main/java/org/apache/asterix/om/functions/IFunctionDescriptor.java
File asterix-om/src/main/java/org/apache/asterix/om/functions/IFunctionDescriptor.java:

Line 39:     public IRunningAggregateEvaluatorFactory createRunningAggregateFunctionFactory(final IScalarEvaluatorFactory[] args)
> s/Function/Evaluator/ ?
Done


Line 42:     public ICopySerializableAggregateFunctionFactory createSerializableAggregateFunctionFactory(
> s/Function/Evaluator/ ?
Done


Line 45:     public IUnnestingEvaluatorFactory createUnnestingFunctionFactory(final IScalarEvaluatorFactory[] args)
> s/Function/Evaluator/ ?
Done


Line 48:     public IAggregateEvaluatorFactory createAggregateFunctionFactory(final IScalarEvaluatorFactory[] args)
> s/Function/Evaluator/ ?
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java
File asterix-om/src/main/java/org/apache/asterix/om/types/ATypeTag.java:

Line 131:         }
> How about
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/collections/ListifyAggregateFunctionEvalFactory.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/collections/ListifyAggregateFunctionEvalFactory.java:

Line 56:             private DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractAvgAggregateFunction.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractAvgAggregateFunction.java:

Line 67:     private DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractCountAggregateFunction.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractCountAggregateFunction.java:

Line 54:     private DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractMinMaxAggregateFunction.java:

Line 48:     protected DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSumAggregateFunction.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/AbstractSumAggregateFunction.java:

Line 56:     protected DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/stream/EmptyStreamAggregateDescriptor.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/stream/EmptyStreamAggregateDescriptor.java:

Line 68:                     private DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


https://asterix-gerrit.ics.uci.edu/#/c/615/7/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/stream/NonEmptyStreamAggregateDescriptor.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/stream/NonEmptyStreamAggregateDescriptor.java:

Line 67:                     private DataOutput out = resultStorage.getDataOutput();
> The relationship between "resultStorage" and "out" is not the obvious when 
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/615
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If132857cf8d707ce96951f12ba6dd86f54aa4069
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes