Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A858518AB4 for ; Sat, 6 Feb 2016 02:06:00 +0000 (UTC) Received: (qmail 22299 invoked by uid 500); 6 Feb 2016 02:06:00 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 22266 invoked by uid 500); 6 Feb 2016 02:06:00 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 22257 invoked by uid 99); 6 Feb 2016 02:06:00 -0000 Received: from Unknown (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 06 Feb 2016 02:06:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 10525C053A for ; Sat, 6 Feb 2016 02:06:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id XU3rwMSljadR for ; Sat, 6 Feb 2016 02:05:59 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id 3A9A843B41 for ; Sat, 6 Feb 2016 02:05:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id 6312A24194F; Fri, 5 Feb 2016 18:01:43 -0800 (PST) Date: Fri, 5 Feb 2016 18:01:43 -0800 From: "Till Westmann (Code Review)" To: Michael Blow CC: Jenkins , Yingyi Bu , abdullah alamoudi , Ian Maxon , Murtadha Hubail Reply-To: tillw@apache.org X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: ASTERIXDB-1271: Revisit UUID Implementation X-Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173 X-Gerrit-ChangeURL: X-Gerrit-Commit: fe46f931d3a594305cb2420b8667a12386c42886 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160206020143.6312A24194F@unhygienix.ics.uci.edu> Till Westmann has posted comments on this change. Change subject: ASTERIXDB-1271: Revisit UUID Implementation ...................................................................... Patch Set 3: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/610/3/asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java File asterix-om/src/main/java/org/apache/asterix/om/base/AMutableUUID.java: Line 41: static final ThreadLocal threadUnique = new ThreadLocal() { I'm wondering if - instead of keeping ThreadLocal state - we could a) externalize the state and keep it within the the consumer (the Evaluator created in CreateUUIDDescriptor) or b) keep it inside the AMutableUUID object as we probably create exactly one of those for each evaluator (however in this case we should probably document this requirement for the use of this class). Does this make sense? What would be the disadvantages? -- To view, visit https://asterix-gerrit.ics.uci.edu/610 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes