Return-Path: X-Original-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Delivered-To: apmail-asterixdb-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 546AA1832C for ; Wed, 3 Feb 2016 22:03:22 +0000 (UTC) Received: (qmail 29563 invoked by uid 500); 3 Feb 2016 22:03:22 -0000 Delivered-To: apmail-asterixdb-notifications-archive@asterixdb.apache.org Received: (qmail 29529 invoked by uid 500); 3 Feb 2016 22:03:22 -0000 Mailing-List: contact notifications-help@asterixdb.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@asterixdb.incubator.apache.org Delivered-To: mailing list notifications@asterixdb.incubator.apache.org Received: (qmail 29520 invoked by uid 99); 3 Feb 2016 22:03:22 -0000 Received: from Unknown (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2016 22:03:22 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D89B51A02AB for ; Wed, 3 Feb 2016 22:03:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.919 X-Spam-Level: X-Spam-Status: No, score=0.919 tagged_above=-999 required=6.31 tests=[SPF_FAIL=0.919] autolearn=disabled Received: from mx1-us-east.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id lpotLhM2wucG for ; Wed, 3 Feb 2016 22:03:21 +0000 (UTC) Received: from unhygienix.ics.uci.edu (unhygienix.ics.uci.edu [128.195.14.130]) by mx1-us-east.apache.org (ASF Mail Server at mx1-us-east.apache.org) with ESMTP id 1240942A42 for ; Wed, 3 Feb 2016 22:03:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by unhygienix.ics.uci.edu (Postfix) with ESMTP id A0CEE2410F3; Wed, 3 Feb 2016 13:59:06 -0800 (PST) Date: Wed, 3 Feb 2016 13:59:06 -0800 From: "Jianfeng Jia (Code Review)" To: abdullah alamoudi CC: Jenkins , Till Westmann Reply-To: jianfeng.jia@gmail.com X-Gerrit-MessageType: comment Subject: Change in asterixdb[master]: Add compatibility for Socket adapter X-Gerrit-Change-Id: I8c8c78598c0cfea36c18503a73b002ece700be71 X-Gerrit-ChangeURL: X-Gerrit-Commit: 71d70dc89cd187f4cbc721108a73a9c967184e81 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Disposition: inline User-Agent: Gerrit/2.8.4 Message-Id: <20160203215906.A0CEE2410F3@unhygienix.ics.uci.edu> Jianfeng Jia has posted comments on this change. Change subject: Add compatibility for Socket adapter ...................................................................... Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/609/1/asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java File asterix-external-data/src/main/java/org/apache/asterix/external/util/ExternalDataCompatibilityUtils.java: Line 58: throw new AsterixException("Unspecified format parameter for HDFS adapter"); Is it easy to implement a switch-case-default statement other than if-else statement such that we won't forget to set some of the configuration in case we add some more adapter in future? Line 87: configuration.put(ExternalDataConstants.KEY_READER_STREAM, ExternalDataConstants.STREAM_SOCKET); I'm not familiar with Feed configurations, could you explain a bit about what are this two configurations about? if we don't set these, what could be wrong? -- To view, visit https://asterix-gerrit.ics.uci.edu/609 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c8c78598c0cfea36c18503a73b002ece700be71 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Jianfeng Jia Gerrit-Reviewer: Till Westmann Gerrit-HasComments: Yes