asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Add DDL support for optionally associating meta record with ...
Date Sat, 27 Feb 2016 04:38:18 GMT
Yingyi Bu has posted comments on this change.

Change subject: Add DDL support for optionally associating meta record with dataset record.
......................................................................


Patch Set 9:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/666/9/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
File asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java:

Line 587:                     if (itemType.getTypeTag() != ATypeTag.RECORD) {
> This is the same check as before?
Done


https://asterix-gerrit.ics.uci.edu/#/c/666/9/asterix-lang-aql/src/main/javacc/AQL.jj
File asterix-lang-aql/src/main/javacc/AQL.jj:

Line 1408:     <LEFTPAREN><RIGHTPAREN> 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/666/9/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj
File asterix-lang-sqlpp/src/main/javacc/SQLPP.jj:

Line 1407:     <LEFTPAREN><RIGHTPAREN> 
> WS
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/666
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I613316985dbd7f553d946f95c5b1a1df56914902
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message