asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1302 ASTERIXDB-1301 Fix Socket Feed Connection
Date Fri, 26 Feb 2016 07:53:03 GMT
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1302 ASTERIXDB-1301 Fix Socket Feed Connection
......................................................................


Patch Set 6:

(3 comments)

Hi,
Just received another message from San Diego asking about these fixes. Can we speed it up
a little bit?

https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java
File asterix-app/src/main/java/org/apache/asterix/aql/translator/QueryTranslator.java:

Line 1228:             //#. prepare jobs which will drop corresponding datasets with indexes.
> Duplicate comment
Done


https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/feeds/drop-dataverse-with-disconnected-feed/drop-dataverse-with-disconnected-feed.1.ddl.aql:

Line 20:  * Description  : Drop a dataverse with disconnected feed 
> WS
Done


https://asterix-gerrit.ics.uci.edu/#/c/660/6/asterix-common/src/test/java/org/apache/asterix/test/client/FileFeedSocketAdapterClient.java
File asterix-common/src/test/java/org/apache/asterix/test/client/FileFeedSocketAdapterClient.java:

Line 76:                     System.err.println("send " + recordCount);
> That potentially might generate a lot of noise in the output.
I have removed it completely since there is no point printing it.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/660
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8f6e982440d3577343f2479c3779653a9c3db614
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ildar Absalyamov <ildar.absalyamov@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message