asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Remove Unneeded Suppress Warnings
Date Thu, 25 Feb 2016 07:03:32 GMT
abdullah alamoudi has submitted this change and it was merged.

Change subject: Remove Unneeded Suppress Warnings
......................................................................


Remove Unneeded Suppress Warnings

When the classes in this change were created, we were using
deprecated Hadoop library. Since we updated the library,
there is no need to suppress deprecation warnings.

Change-Id: I710c1efbe006ee6de22299f8e6e833a566fb884d
Reviewed-on: https://asterix-gerrit.ics.uci.edu/656
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Murtadha Hubail <hubailmor@gmail.com>
Reviewed-by: Till Westmann <tillw@apache.org>
Reviewed-by: Michael Blow <michael.blow@couchbase.com>
---
M hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/ConfFactory.java
M hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/InputSplitsFactory.java
2 files changed, 1 insertion(+), 4 deletions(-)

Approvals:
  Michael Blow: Looks good to me, but someone else must approve
  Murtadha Hubail: Looks good to me, approved
  Till Westmann: Looks good to me, approved
  Jenkins: Verified



diff --git a/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/ConfFactory.java
b/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/ConfFactory.java
index ad6b0c9..3840167 100644
--- a/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/ConfFactory.java
+++ b/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/ConfFactory.java
@@ -25,10 +25,8 @@
 import java.io.Serializable;
 
 import org.apache.hadoop.mapred.JobConf;
-
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 
-@SuppressWarnings("deprecation")
 public class ConfFactory implements Serializable {
     private static final long serialVersionUID = 1L;
     private byte[] confBytes;
diff --git a/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/InputSplitsFactory.java
b/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/InputSplitsFactory.java
index 8eb03c6..927eb54 100644
--- a/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/InputSplitsFactory.java
+++ b/hyracks/hyracks-hdfs/hyracks-hdfs-core/src/main/java/org/apache/hyracks/hdfs/dataflow/InputSplitsFactory.java
@@ -29,10 +29,9 @@
 
 import org.apache.hadoop.mapred.FileSplit;
 import org.apache.hadoop.mapred.InputSplit;
-
 import org.apache.hyracks.api.exceptions.HyracksDataException;
 
-@SuppressWarnings({ "deprecation", "rawtypes" })
+@SuppressWarnings({ "rawtypes" })
 public class InputSplitsFactory implements Serializable {
 
     private static final long serialVersionUID = 1L;

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/656
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I710c1efbe006ee6de22299f8e6e833a566fb884d
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message