asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Fixes for Coverity Issues
Date Wed, 24 Feb 2016 00:54:06 GMT
Hello Yingyi Bu, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/658

to look at the new patch set (#2).

Change subject: Fixes for Coverity Issues
......................................................................

Fixes for Coverity Issues

(https://scan.coverity.com/projects/hyracks)

- CID 68257 (#1 of 1): Resource leak (RESOURCE_LEAK)
5. leaked_resource: Variable outputStream going out of scope leaks the
 resource it refers to.
- CID 68260 (#1 of 1): Useless call (USELESS_CALL)
side_effect_free: Calling equivalentVars.get(0) is only useful for its
 return value, which is ignored.
- CID 68261 (#1 of 1): BC: Bad casts of object references
 (FB.BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS)
1. defect: Equals method for org.apache.hyracks.algebricks.core.
algebra.properties.LocalOrderProperty assumes the argument is of type
 LocalOrderProperty.
- CID 68262 (#1 of 1): BC: Bad casts of object references
(FB.BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS)
1. defect: Equals method for org.apache.hyracks.storage.am.rtree.
RTreeCheckTuple assumes the argument is of type RTreeCheckTuple.

Change-Id: I8ba6e578f173b1081a8f55b228704744f08588df
---
M algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/properties/LocalOrderProperty.java
M algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/RemoveRedundantVariablesRule.java
M hyracks/hyracks-dataflow-std/src/main/java/org/apache/hyracks/dataflow/std/file/RecordWriter.java
M hyracks/hyracks-test-support/src/main/java/org/apache/hyracks/storage/am/rtree/RTreeCheckTuple.java
4 files changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/hyracks refs/changes/58/658/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/658
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8ba6e578f173b1081a8f55b228704744f08588df
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>

Mime
View raw message