asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Enabled Feed Tests and Added External Library tests
Date Mon, 22 Feb 2016 17:00:30 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Enabled Feed Tests and Added External Library tests
......................................................................


Patch Set 16:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java
File asterix-external-data/src/main/java/org/apache/asterix/external/api/IRecordReader.java:

Line 62:     // TODO: Find a better way to do flushes, this doesn't fit here
> Could you add a JIRA issue pointing to this interface?
Done


Line 69:     // TODO: Find a better way to perform logging. this doesn't fit here
> Could you add a JIRA issue pointing to this interface?
Done


https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:

Line 66:             this.maxRecordSize = ctx.getInitialFrameSize() * 2;
> Shouldn't this be divided by 2?
That is what I did at first. turned out the frame size was configured to be 32kb and ctx.getInitialFrameSize()
returned 8kb. I tried to somehow get the actual configured frame size but it was taking a
lot of time to do it so I thought this might suffice.


https://asterix-gerrit.ics.uci.edu/#/c/625/16/asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java
File asterix-external-data/src/main/java/org/apache/asterix/external/provider/DataflowControllerProvider.java:

Line 66:     // TODO: Instead, use a factory just like data source and data parser.
> Please add a JIRA issue.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/625
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd1fccd136fa2645b2707bbf7c04e60991ae8d4a
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message