asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Support Sending Messages Alongside Frame Data
Date Wed, 17 Feb 2016 07:09:54 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Support Sending Messages Alongside Frame Data
......................................................................


Patch Set 3:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/605/3/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java
File asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedTupleForwarder.java:

Line 54:         if (ctx.getSharedObject() == null) {
> Should this be re-written to avoid calling getSharedObject() twice?  It see
Done


https://asterix-gerrit.ics.uci.edu/#/c/605/3/asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java
File asterix-external-data/src/main/java/org/apache/asterix/external/feed/runtime/IngestionRuntime.java:

Line 61:             synchronized (ctx) {
> Probably there's a good reason, but why is this mutation of the shared obje
Mmmm, I didn't think others needed to be synchronized since they are only called once but
this one can be called multiple times. however, after a closer inspection, the one in FeedTupleForwarder
also needs to be synchronized.


https://asterix-gerrit.ics.uci.edu/#/c/605/3/asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java
File asterix-external-data/src/main/java/org/apache/asterix/external/operators/FeedMetaStoreNodePushable.java:

Line 173:             e.printStackTrace();
> Remove printStackTrace() (understood not introduced with this change)
Done


https://asterix-gerrit.ics.uci.edu/#/c/605/3/asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedMessageUtils.java
File asterix-external-data/src/main/java/org/apache/asterix/external/util/FeedMessageUtils.java:

Line 27:     public static final byte NULL_FEED_MESSAGE = 0;
> Do these correspond to the enum items?  If so, should we make these Message
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/605
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa23e9f8a909ddcafc1c3ee95181092eb04ee1ad
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sjaco002@ucr.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message