asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Prove test for BigObject Groupby & Join
Date Tue, 16 Feb 2016 17:46:13 GMT
Till Westmann has posted comments on this change.

Change subject: Prove test for BigObject Groupby & Join
......................................................................


Patch Set 9:

I'm a little confused by this change. You're saying that it verifies something, but the only
diff I see is a null-check in ARecordType.toString().

Could you clarify?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/451
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aadec904af64cc2b7b03e6dff399a2288c21a7b
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: No

Mime
View raw message