asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1272 Remove ExternalLookupOperator
Date Tue, 16 Feb 2016 07:44:14 GMT
abdullah alamoudi has posted comments on this change.

Change subject: ASTERIXDB-1272 Remove ExternalLookupOperator
......................................................................


Patch Set 11:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/592/11/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceInstantLockSearchCallbackRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceInstantLockSearchCallbackRule.java:

Line 70:                     if (fid.equals(AsterixBuiltinFunctions.EXTERNAL_LOOKUP)) {
> I'm not sure why the function used for external index search couldn't just 
In this case, this is not the index search but the external data lookup actually as in, we're
using RIDs to read records from HDFS and hence, locking doesn't make sense at all. we need
to be able to distinguish between the two cases and I am using the function id to do so.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/592
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9a9400586b75fd8cb3c0b8f4aeb45aee76cdb92
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Yingyi Bu <yingyib@google.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message