asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix ASTERIXDB-1292
Date Tue, 16 Feb 2016 05:02:12 GMT
Till Westmann has posted comments on this change.

Change subject: Fix ASTERIXDB-1292
......................................................................


Patch Set 2:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/636/2/asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java
File asterix-om/src/main/java/org/apache/asterix/om/base/temporal/DateTimeFormatUtils.java:

Line 878:                         int valFieldCount = (int) Math.ceil(Math.log10(val + 0.1));
Couldn't we just use the length of String.valueOf(val) here?


Line 907:                         int msFieldCount = (int) Math.ceil(Math.log10(ms + 0.1));
Same here?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/636
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8e9b87145d9b3511874cd11d61ae87acdc94c7
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message