asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Westmann (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Allow Project Runtime to Pass Through an Empty Frame
Date Mon, 15 Feb 2016 05:07:11 GMT
Till Westmann has posted comments on this change.

Change subject: Allow Project Runtime to Pass Through an Empty Frame
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

Feel free to forward the +2, if you decide to address the comments.

https://asterix-gerrit.ics.uci.edu/#/c/634/2//COMMIT_MSG
Commit Message:

Line 9: Before this change, project runtime expects at least a single record. now it can also
process an empty frame.
Could we keep the lines in the comment to 77 chars?
Also, the change in RegisterNodeWork should be mentioned.


https://asterix-gerrit.ics.uci.edu/#/c/634/2/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/StreamProjectRuntimeFactory.java
File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/std/StreamProjectRuntimeFactory.java:

Line 78:                         }
Couldn't we just do

    for (int t = 0; t < nTuple - 1; t++) {
        appendProjectionToFrame(t, projectionList);
    }

Is there additional value in the if-statement?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/634
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87dc6eb83a748f7f91610e7d11ebaec9be914e29
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-HasComments: Yes

Mime
View raw message