asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jianfeng Jia (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Intersect the 2ndary indexes before primary search
Date Sun, 14 Feb 2016 07:08:16 GMT
Jianfeng Jia has posted comments on this change.

Change subject: Intersect the 2ndary indexes before primary search
......................................................................


Patch Set 3:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/578/3/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java:

Line 148:             // one primary + 2nd indexes, choose primary index directly.
> 2nd->secondary
Done


Line 178:                 throw new AlgebricksException("The data source root should be the
same");
> "be the same" -->"have the same operator type."
Done


Line 183:             if (lop.getInputs().get(0).getValue().getOperatorTag() != LogicalOperatorTag.ORDER)
{
> This check seems not necessary.
Done


Line 192:                     throw new AlgebricksException("It should not happen, the order
by expression is not variables");
> It seems that the code can be simplified a bit because the intersect only c
Good point. But when I apply this changes, I found that the number of liveVars is 6. It seems
all variables through the datascan to unnestmap were alive at this stage. Any ideas?


Line 207:         intersect.setExecutionMode(AbstractLogicalOperator.ExecutionMode.LOCAL);
> Is this necessary?  The SetExecutionModeRule will be applied later in physi
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/578
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie167918fb23e39c8728840e4a90c1b85bf1bde85
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message