asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Fix for ASTERIXDB-1205
Date Fri, 12 Feb 2016 06:31:16 GMT
Yingyi Bu has posted comments on this change.

Change subject: Fix for ASTERIXDB-1205
......................................................................


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/629/3/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/FuzzyJoinRule.java:

Line 269:                 context, context);
> Why is the same argument passed twice? It appears the class now takes two d
The first parameter is IVariableContext and the second parameter ITypingContext.  IOptimizationContext
implemented both so it is passed in twice.
It is described in the commit message of the algebricks change:
https://asterix-gerrit.ics.uci.edu/#/c/628/

That change makes the operator deep copy visitor useful at places where types are not available
yet, for example, in the LanguageToExpressionTranslator.

It is not directly related to the fix for ASTERIXDB-1205, but will be beneficial to get the
SQL++ join query plan right.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/629
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79a899ec4b35ece6f8f9f59b80126fed0c48851
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message