asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Young-Seok Kim (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Unblock Dataset Level Lock for Concurrent Jobs
Date Fri, 12 Feb 2016 06:08:32 GMT
Young-Seok Kim has posted comments on this change.

Change subject: Unblock Dataset Level Lock for Concurrent Jobs
......................................................................


Patch Set 1:

[A note that I wrote but forgot to add as comments]

The caller thread of decrementNumActiveOperations() is only one thread, i.e., the logFlusher
thread. 

The caller threads of incrementNumActiveOperations() can be multiple writer threads who are
serving for AsterixLSMInsertDelete/UpsertOperatorNodePushable object.  

The caller threads of unblockConcurrentTransactions() will be the same caller threads of incrementNumActiveOperations().

1) I want to make sure that the variable, waiting, is correctly set to false and true by those
threads. 
2) Also, I want to make sure that transactorNumActiveOperations.get()  function and wait()
function are correctly called in order to make wait() and notifyAll() work in expected manner.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/619
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79bc17dbcc596023bec9122c4425596a2f96a574
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: No

Mime
View raw message