asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: Move to non-copy-based evaluator interfaces for all function...
Date Thu, 11 Feb 2016 15:15:03 GMT
abdullah alamoudi has posted comments on this change.

Change subject: Move to non-copy-based evaluator interfaces for all function implementations,
including: - scalar functions, - aggregate functions, - running aggregate functions, - unnesting
functions
......................................................................


Patch Set 14:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/615/14/asterix-app/src/test/resources/runtimets/results/string/substring-after-4/substring-after-4.1.adm
File asterix-app/src/test/resources/runtimets/results/string/substring-after-4/substring-after-4.1.adm:

Line 1: { "result1": "HEllow", "result2": null, "result3": null, "result4": "", "result5":
null }
I thought this change is not supposed to change results!!!


https://asterix-gerrit.ics.uci.edu/#/c/615/14/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/ARecordSerializerDeserializer.java:

Line 241:                     }
why add the offset to the integer while at the same time, it is used within the getIng?. this
seems wrong.

It seems like we want to use two different offsets here!!


Line 252:                     }
why add the offset to the integer?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/615
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If132857cf8d707ce96951f12ba6dd86f54aa4069
Gerrit-PatchSet: 14
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Preston Carman <prestonc@apache.org>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message