asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "abdullah alamoudi (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Fixed a Bug in the Register Node Work
Date Thu, 11 Feb 2016 08:54:58 GMT
abdullah alamoudi has submitted this change and it was merged.

Change subject: Fixed a Bug in the Register Node Work
......................................................................


Fixed a Bug in the Register Node Work

When registering a node, in order to allow multiple nodes to
share an ip address, we store them in a map <ipaddress,List<nodeNames>>
However, the way we check for the existence of an entry had a bug in it
which causes the entry to never be found.

Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Reviewed-on: https://asterix-gerrit.ics.uci.edu/624
Tested-by: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Reviewed-by: Ian Maxon <imaxon@apache.org>
---
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Ian Maxon: Looks good to me, approved
  Jenkins: Verified



diff --git a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
index 7ac0641..dd26ea4 100644
--- a/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
+++ b/hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/RegisterNodeWork.java
@@ -72,7 +72,7 @@
             }
             ncConfiguration = new HashMap<String, String>();
             state.getNCConfig().toMap(ncConfiguration);
-            Set<String> nodes = ipAddressNodeNameMap.get(ipAddress);
+            Set<String> nodes = ipAddressNodeNameMap.get(InetAddress.getByName(ipAddress));
             if (nodes == null) {
                 nodes = new HashSet<String>();
                 ipAddressNodeNameMap.put(InetAddress.getByName(ipAddress), nodes);

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/624
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I39273c2d72cee0f85187febc9a2b1a6086181e66
Gerrit-PatchSet: 2
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>

Mime
View raw message