asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in hyracks[master]: Move to non-copy-based evaluator interfaces for scalar funct...
Date Thu, 11 Feb 2016 01:35:48 GMT
Yingyi Bu has posted comments on this change.

Change subject: Move to non-copy-based evaluator interfaces for scalar functions, aggregate
functions, running aggregate functions and unnest functions.
......................................................................


Patch Set 5:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/614/5/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ISerializedAggregateEvaluator.java
File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/ISerializedAggregateEvaluator.java:

Line 32:      * @return length of the intermediate state
> Extraneous @return?  (i.e. void)
Done


https://asterix-gerrit.ics.uci.edu/#/c/614/5/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluator.java
File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluator.java:

Line 29: 
> What is the correct whitespace here at end of class prior to closing }?
I guess either with or without a new line is fine.  It looks the code formatter we use doesn't
mind either case.


https://asterix-gerrit.ics.uci.edu/#/c/614/5/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluatorFactory.java
File algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/base/IUnnestingEvaluatorFactory.java:

Line 28: }
> What is the correct whitespace here at end of class prior to closing }?
I guess either with or without a new line is fine.  It looks the code formatter we use doesn't
mind either case.


https://asterix-gerrit.ics.uci.edu/#/c/614/5/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
File hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java:

Line 98:      *            - Byte offset
> why newline?
Our formatter added that. The original code did not use the right code style formatter.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/614
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92a630550f3d45a7a5f00cfbc93e7b049b06330d
Gerrit-PatchSet: 5
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message