asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yingyi Bu (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1157: Implemented Limit Pushdown into Order (Exter...
Date Tue, 09 Feb 2016 22:45:42 GMT
Yingyi Bu has posted comments on this change.

Change subject: ASTERIXDB-1157: Implemented Limit Pushdown into Order (ExternalSort)
......................................................................


Patch Set 2:

(8 comments)

https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java
File asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/PushLimitIntoOrderByRule.java:

Line 116:                 && limitOp.getOffset().getValue().getExpressionTag() ==
LogicalExpressionTag.CONSTANT) {
if limitOp.getOffset().getValue().getExpressionTag() != LogicalExpressionTag.CONSTANT, we'd
have to return false.


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-primary-limit-orderby-01.aql
File asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-primary-limit-orderby-01.aql:

Line 28: create dataverse test;
The test name as well as its directory is a bit confusing. 
Can you rename it to "orderby_limit_01" move this test to a the top level directory optimizerts/queries/?


Line 61: limit 2
Could you add another test case where offset is not null.


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-primary-limit-orderby-02.aql
File asterix-app/src/test/resources/optimizerts/queries/btree-index/btree-primary-limit-orderby-02.aql:

Line 29: use dataverse test;
Can you rename this test case to "orderby_limit_primary_index" move this test to the top level
directory optimizerts/queries/?


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/optimizerts/results/btree-index/btree-primary-limit-orderby-01.plan
File asterix-app/src/test/resources/optimizerts/results/btree-index/btree-primary-limit-orderby-01.plan:

Line 9:                 -- STABLE_SORT [$$10(ASC)]  |PARTITIONED|
Could you add the "topK" information in the pretty printing of STABLE_SORT?

For example:

-- STABLE_SORT [topK=5] [$$10(ASC)]


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-01/btree-index-limit-orderby-01.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-01/btree-index-limit-orderby-01.1.ddl.aql:

Line 18:  */
rename the test and move it to a new directory:
runtimets/queries/orderby_limit/


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-01/btree-index-limit-orderby-01.3.query.aql
File asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-01/btree-index-limit-orderby-01.3.query.aql:

Line 30: order by $o.docid
add another test where offset != null


https://asterix-gerrit.ics.uci.edu/#/c/617/2/asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-02/btree-index-limit-orderby-02.1.ddl.aql
File asterix-app/src/test/resources/runtimets/queries/index-selection/btree-index-limit-orderby-02/btree-index-limit-orderby-02.1.ddl.aql:

Line 29: 
rename the test and move it to a new directory:
runtimets/queries/orderby_limit/


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/617
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I19aa4ce402b1834d9f68320acb72d7635a41a837
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Jianfeng Jia <jianfeng.jia@gmail.com>
Gerrit-Reviewer: Taewoo Kim <wangsaeu@gmail.com>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: Young-Seok Kim <kisskys@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message