asterixdb-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Blow (Code Review)" <do-not-re...@asterixdb.incubator.apache.org>
Subject Change in asterixdb[master]: ASTERIXDB-1271: Revisit UUID Implementation
Date Sun, 07 Feb 2016 12:51:25 GMT
Michael Blow has posted comments on this change.

Change subject: ASTERIXDB-1271: Revisit UUID Implementation
......................................................................


Patch Set 4:

(6 comments)

https://asterix-gerrit.ics.uci.edu/#/c/610/4/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AUUIDPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/adm/AUUIDPrinter.java:

Line 26: import org.apache.hyracks.algebricks.data.IPrinter;
> remove unused LongPointable import?
Done


Line 38:     public void print(byte[] b, int s, int l, PrintStream ps) throws AlgebricksException
{
> object creation on a per record basis. we should either fix this, or add a 
I have eliminated the intermediate StringBuilder construction in the next patch, I believe
that the JVM will allocate the only remaining StringBuilder on the stack, so there should
be no GC involved.


https://asterix-gerrit.ics.uci.edu/#/c/610/4/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AUUIDPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/csv/AUUIDPrinter.java:

Line 39:         ps.print("\"" + AUUID.toStringLiteralOnly(b, s + 1) + "\"");
> object creation on a per record basis. we should either fix this, or add a 
I have eliminated the intermediate StringBuilder construction in the next patch, I believe
that the JVM will allocate the only remaining StringBuilder on the stack, so there should
be no GC involved.


https://asterix-gerrit.ics.uci.edu/#/c/610/4/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AUUIDPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/clean/AUUIDPrinter.java:

Line 39:         ps.print("\"" + AUUID.toStringLiteralOnly(b, s + 1) + "\"");
> object creation on a per record basis. we should either fix this, or add a 
I have eliminated the intermediate StringBuilder construction in the next patch, I believe
that the JVM will allocate the only remaining StringBuilder on the stack, so there should
be no GC involved.


https://asterix-gerrit.ics.uci.edu/#/c/610/4/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AUUIDPrinter.java
File asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/printers/json/lossless/AUUIDPrinter.java:

Line 39:         ps.print("\"" + AUUID.toStringLiteralOnly(b, s + 1) + "\"");
> object creation on a per record basis. we should either fix this, or add a 
I have eliminated the intermediate StringBuilder construction in the next patch, I believe
that the JVM will allocate the only remaining StringBuilder on the stack, so there should
be no GC involved.


https://asterix-gerrit.ics.uci.edu/#/c/610/4/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreateUUIDDescriptor.java
File asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/CreateUUIDDescriptor.java:

Line 20: 
> remove unused imports
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/610
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e90d42f6b62f80ad180dbd0c8c852db85b14173
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Ian Maxon <imaxon@apache.org>
Gerrit-Reviewer: Jenkins <jenkins@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <michael.blow@couchbase.com>
Gerrit-Reviewer: Murtadha Hubail <hubailmor@gmail.com>
Gerrit-Reviewer: Till Westmann <tillw@apache.org>
Gerrit-Reviewer: Yingyi Bu <buyingyi@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamousaa@gmail.com>
Gerrit-HasComments: Yes

Mime
View raw message